search

fedora-python / python-ethtool

Deprecated Python bindings for the ethtool kernel interface
GNU General Public License v2.0
15 stars 13 forks source link

make tests compatible with Python 3.12 #60

Closed dotlambda closed 2 weeks ago

hroncok commented 1 month ago

Thank you. The change looks reasonable, but the CI is broken (used to be Travis CI). Will need to verify this manually.

hroncok commented 1 month ago

Ok, this works on 3.6+ including 3.12 and 3.13 but fails on 2.7.

@frenzymadness Do we care about 2.7?

frenzymadness commented 2 weeks ago

I'm sorry for the delay. I don't think we care about Python 2 anymore but I think that the cost of making this change backward-compabible is also not that high.

Would it make sense to not break it now. Given the amount of changes we receive here.