search

fedora-python / tox-current-env

tox plugin to run tests in current Python environment
https://pypi.org/project/tox-current-env/
MIT License
23 stars 8 forks source link

Create current environemnt link when --print-deps-only has no env #10

Closed hroncok closed 5 years ago

hroncok commented 5 years ago

(Better reviewed commit by commit.)

encukou commented 5 years ago

With this, after you run rm -r .tox; tox --print-deps-only, regular tox seems to consider the environment created and will try to install dependencies into the current environment.

hroncok commented 5 years ago

regular tox seems to consider the environment created and will try to install dependencies into the current environment.

I'll update the "unsupported" check.

hroncok commented 5 years ago

I've amended tests and docs, but I think the situation you are describing is not happening. Could you please give full reproducer?

hroncok commented 5 years ago

In other words:

After you run rm -r .tox; tox --print-deps-only, regular tox aborts with "not supported". At least that is what I believe test_regular_after_first_deps_only_is_not_supported is checking.

hroncok commented 5 years ago

Oh, it aborts after it installs the package :(

hroncok commented 5 years ago

Added a test that finds out about this.

hroncok commented 5 years ago

Fixed.

Also, in the future, we could simply always delete the fake environment in tox_cleanup hook and get rid of this restriction, but I'll leave that to another PR.

hroncok commented 5 years ago

Opened https://github.com/fedora-python/tox-current-env/issues/14 as a followup.