search

fedora-selinux / setroubleshoot

Abandoned, use https://gitlab.com/setroubleshoot
https://gitlab.com/setroubleshoot
9 stars 12 forks source link

Hide "Report bug" button when mozplugger plugin is used. BZ(1290135) #10

Closed wrabcak closed 7 years ago

wrabcak commented 8 years ago

This force users to use SELinux booleans: mozilla_plugin_can_network_connect unconfined_mozilla_plugin_transition instead of reporting this kind of SELinux troubles.

mgrepl commented 8 years ago

Could we handle it directly in Plugins? It does not seem to be correct to modify GUI for this purpose.

mgrepl commented 8 years ago

@wrabcak What is a status here? I see a lot of bugs related to this issue.

bachradsusi commented 8 years ago

The filtering should be done when we collect signatures and solutions from plugins. The question which needs to be answered is, what are the conditions when we don't want to show "Report bug" button or even when we don't want to represent catchall plugin at all

From the pull request description, I understand that "Report bug" could be hide when mozplugger plugin suggests something.

framework/src/setroubleshoot/signature.py:451 def get_plugins(self, all = False) seems to be the right function for this.

mgrepl commented 8 years ago

@bachradsusi Yes, this issue is for the mozplugger plugin.