search

fedora-selinux / setroubleshoot

Abandoned, use https://gitlab.com/setroubleshoot
https://gitlab.com/setroubleshoot
9 stars 12 forks source link

plugins: Text and whitespace fixes #11

Closed dperpeet closed 8 years ago

dperpeet commented 8 years ago

If/Then sentences should now uniformly begin with a capital letter. Also minor python whitespace cleanup.

The Cockpit ui plugin for setroubleshoot (wip: https://github.com/cockpit-project/cockpit/pull/3962/) would look better if the Messages started with capitalized letters.

Is there a way to preserve translations? I don't want to break all the work that's been done for minor changes.

bachradsusi commented 8 years ago

Thanks for the patch.

if_text is always wrapped with _("If ") therefore if sentences should not start with a capital letter.

I would rather have two patches here, one for the text changes and other for whitespace fixes.

Please use fedora-selinux:python3 branch as a development base. master is considered as legacy python2 while all new things goes to python3. We need to document it and probably change the structure to be more consistent.

As for the translations, we use fedora.zanata.org. It should be feasible to merge old translations with new strings. However I need to check it and find out how.

dperpeet commented 8 years ago

Interesting.

iftext is always wrapped with ("If ") therefore if sentences should not start with a capital letter.

Via dbus api you deliver the text including the "If ", correct? Am I correct to assume that the "if" text in plugins should start with lower case? Or is that done programmatically?

What about conditions for 'then' and 'do'? The 'do' part seems especially heterogeneous.

I will change this pr and split the modifications.

bachradsusi commented 8 years ago

"If " is added in browser and using DBUS api as well.

We need to change strings to already contain "If " on the beginning since sometime is simply not possible to put "If" in other language to the beginning of a sentence.

bachradsusi commented 8 years ago

Note: it will be fixed by https://github.com/bachradsusi/setroubleshoot/commits/rework-plugin-strings . However I need to be synchronized with translation team. See bugs https://bugzilla.redhat.com/show_bug.cgi?id=1322734 and https://bugzilla.redhat.com/show_bug.cgi?id=1210243

bachradsusi commented 7 years ago

The change described in https://github.com/fedora-selinux/setroubleshoot/pull/11#issuecomment-217410582 is applied in master branch now - https://github.com/fedora-selinux/setroubleshoot/commit/98c2ad7c16be9b79f880964b3ccfbfbc5bb4ed58