fedora-silverblue / issue-tracker

Fedora Silverblue issue tracker
https://fedoraproject.org/atomic-desktops/silverblue/
126 stars 3 forks source link

OS Version has patch date appended #424

Closed DEM0NAssissan7 closed 1 year ago

DEM0NAssissan7 commented 1 year ago

This issue tracker is intended only for Silverblue specific issues. We would like to ask you to try to reproduce the issue on a relevant Fedora Workstation release. If you will be able to reproduce there, then please report it in Red Hat Bugzilla (see How to file a bug) or in upstream (preferred for GNOME projects) and not in this issue tracker.

Describe the bug A clear and concise description of what the bug is. In /etc/os-release, the version string has the image date appended to it. This creates a confusing version number for the end user who may not understand what the extra numbers appended to "37" mean.

To Reproduce Please describe the steps needed to reproduce the bug:

  1. Look at /etc/os-release and notice that the version string has the image date appended to it [37.20230221.0 (Silverblue)]
  2. This also appears in the GNOME Settings [About] page.

Expected behavior The version number should only include 37 and not the date of the image.

Screenshots Screenshot from 2023-02-22 20-50-04 Screenshot from 2023-02-22 20-49-47

OS version:

BootedDeployment:
● fedora:fedora/37/x86_64/silverblue
                  Version: 37.20230221.0 (2023-02-21T00:44:37Z)
               BaseCommit: 521691fcb10306daf330ad64fa04ad23097a05b5adaebe2f1ef4c170c679b9e8

Additional context Fedora Workstation does not have this phenomenon. Silverblue should be consistent with this behaviour in the DNF based Fedora versions.

miabbott commented 1 year ago

Besides the lack of consistency with Workstation, how does this impact end users? Are there other problems/bugs that are rooted in this difference?

LorbusChris commented 1 year ago

This is a feature, not a bug, isn't it? In Silverblue the OS image as a whole is versioned, as each image comes from a versioned compose

DEM0NAssissan7 commented 1 year ago

The issue is that it will be confusing for end users. The extra numbers make the version number a lot more confusing. Perhaps there is a better way to append the OS image version to the VERSION tag instead of having it right in front of the Fedora release version.

travier commented 1 year ago

It's already in the version tag:

$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="37.20230220.0 (Kinoite)"
ID=fedora
VERSION_ID=37
VERSION_CODENAME=""
PLATFORM_ID="platform:f37"
PRETTY_NAME="Fedora Linux 37.20230220.0 (Kinoite)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:37"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://kinoite.fedoraproject.org"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora-kinoite/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://pagure.io/fedora-kde/SIG/issues"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=37
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=37
SUPPORT_END=2023-11-14
VARIANT="Kinoite"
VARIANT_ID=kinoite
OSTREE_VERSION='37.20230220.0'

We can consider disabling that but I don't think that would be useful. This version is also the one displayed in GRUB if I'm not mistaken thus we need it.

DEM0NAssissan7 commented 1 year ago

Perhaps we should clear it from PRETTY_NAME as that is the one most users will see (in GUIs). As said previously, the extra numbers may confuse end users.