fedora-silverblue / issue-tracker

Fedora Silverblue issue tracker
https://fedoraproject.org/atomic-desktops/silverblue/
126 stars 3 forks source link

New Package Request: git-credential-libsecret #428

Open CheariX opened 1 year ago

CheariX commented 1 year ago

Please try to answer the following questions about the package you are requesting:

  1. Is the package installed by default in Fedora Workstation? If it is not, we will ask you to open an issue in the issue tracker for the Fedora Workstation Working Group.

Not sure. I think the answer is "no".

  1. What, if any, are the additional dependencies on the package? What is the output of this command on a system without overrides or locally installed packages:
rpm-ostree install --dry-run <package>
TODO
  1. What is the size of the package and its dependencies?
rpm -qi git-credential-libsecret
Name        : git-credential-libsecret
Version     : 2.39.2
Release     : 1.fc38
Architecture: x86_64
Install Date: Mon 06 Mar 2023 06:10:23 PM CET
Group       : Unspecified
Size        : 20633
License     : BSD-3-Clause AND GPL-2.0-only AND GPL-2.0-or-later AND LGPL-2.1-or-later AND MIT
Signature   : RSA/SHA256, Tue 14 Feb 2023 08:26:06 PM CET, Key ID 809a8d7ceb10b464
Source RPM  : git-2.39.2-1.fc38.src.rpm
Build Date  : Tue 14 Feb 2023 08:05:40 PM CET
Build Host  : buildvm-x86-21.iad2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://git-scm.com/
Bug URL     : https://bugz.fedoraproject.org/git
Summary     : Git helper for accessing credentials via libsecret
Description :
Git helper for accessing credentials via libsecret.
  1. What problem are you trying to solve with this package? Or what functionality does the package provide?

If I install an IDE via Flatpak, such as VSCode, it cannot handle GIT repos via HTTPs: it cannot store credentials.

Silverblue supposes to install flatpak apps before any other solution, so I assumed this to work since git is already installed. I think, it will be the same for any other Flatpak GIT-Tools (not tried).

git-credential-libsecret integrates nicely into a GNOME Desktop via gnome-keyring.

  1. Can the software provided by the package be run from a container? Explain why or why not.

I can install it in toolbox, and install VSCode therin. But this is not what the prefered way (flatpak).

I could also switch to git via SSH but HTTPs is preferred for security reasons.

  1. Can the tool(s) provided by the package be helpful in debugging container runtime issues?

no

  1. Can the tool(s) provided by the package be helpful in debugging networking issues?

no

  1. Is it possible to layer the package locally via rpm-ostree install <package>? Explain why or why not.

Yes.

travier commented 1 year ago

I can install it in toolbox, and install VSCode therin. But this is not what the prefered way (flatpak).

I'd say to preferred way is to use the remote container extension with VS Code to use a toolbox as environment.

I'm not strictly opposed to adding it however.

CheariX commented 1 year ago

I'd say to preferred way is to use the remote container extension with VS Code to use a toolbox as environment.

This seems to work only for toolbox (i guess, because i installed git-credential-libsecret). If use remote containers with regular containers, VSCode automatically overwrites my git config with something like:

[credential]
    helper = "!f() { /home/vscode/.vscode-server/bin/e2816fe719a4026ffa1ee0189dc89bdfdbafb164/node /tmp/vscode-remote-containers-e2e0dc61-8fc2-46ea-831b-b21c6941b782.js git-credential-helper $*; }; 

which in turn speaks to the host (where git-credential-libsecret does not exist).