fedora-silverblue / issue-tracker

Fedora Silverblue issue tracker
https://fedoraproject.org/atomic-desktops/silverblue/
122 stars 3 forks source link

Default partition layout install - ESP too small for fwupdmgr updates #459

Closed Naheem closed 6 months ago

Naheem commented 1 year ago

This issue tracker is intended only for Silverblue specific issues. We would like to ask you to try to reproduce the issue on a relevant Fedora Workstation release. If you will be able to reproduce there, then please report it in Red Hat Bugzilla (see How to file a bug) or in upstream (preferred for GNOME projects) and not in this issue tracker.

Describe the bug On a new install of Silverblue 38 (and before wiping the drive, on the previous Silverblue 37 that had been upgraded over time from an earlier install), I cannot install a UEFI system update presented via gnome-software and fwupdmgr. To Reproduce Please describe the steps needed to reproduce the bug:

$ fwupdmgr update
Devices with no available firmware updates: 
 • DELL08D7:00 04F3:30C4
 • KXG50ZNV512G NVMe TOSHIBA 512GB
 • SSD 860 QVO 1TB
╔══════════════════════════════════════════════════════════════════════════════╗
║ Upgrade System Firmware from 1.7.0 to 1.16.0?                                ║
╠══════════════════════════════════════════════════════════════════════════════╣
║ Fixes and Enhancements :                                                     ║
║                                                                              ║
║ ------------------                                                           ║
║                                                                              ║
║ Enhancements:                                                                ║
║                                                                              ║
║ • Firmware updates to address security vulnerabilities.                      ║
║                                                                              ║
║ Inspiron 3585 must remain plugged into a power source for the duration of    ║
║ the update to avoid damage.                                                  ║
╚══════════════════════════════════════════════════════════════════════════════╝
Perform operation? [Y|n]: y
Decompressing…           [                                       ]
/run/media/root/FA4A-9BC7 does not have sufficient space, required 58.1 MB, got 28.3 MB

Expected behavior For the install to complete.

Screenshots If applicable, add screenshots to help explain your problem.

OS version:

● fedora:fedora/38/x86_64/silverblue
                  Version: 38.20230421.0 (2023-04-21T00:46:34Z)
               BaseCommit: 3cfd4aa4de1a4e47f2c607186408f22f1607bcfe4953311eea1e8f7c0c81e453
             GPGSignature: Valid signature by 6A51BBABBA3D5467B6171221809A8D7CEB10B464
          LayeredPackages: langpacks-en_GB

Additional context I created a bug at fwupd who closed it "You don't have enough free space on your ESP." https://github.com/fwupd/fwupd/issues/5737 but this is default Fedora install on a 512GB SSD which created a 629MB /boot/efi partition (gnome disck utility states 616MB free - 2.1% full) and a 1.1GB /boot partition (829MB free - 22.8% full).

travier commented 1 year ago

Can you provide the df -h output for /boot & /efi as well as lsblk and the full rpm-ostree status output?

Naheem commented 1 year ago
$ df -h /boot
Filesystem      Size  Used Avail Use% Mounted on
/dev/nvme0n1p2  974M  183M  724M  21% /boot
$ df -h /boot/efi
Filesystem      Size  Used Avail Use% Mounted on
/dev/nvme0n1p1  599M   12M  588M   2% /boot/efi
$ lsblk
NAME                MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS
sda                   8:0    0 931.5G  0 disk 
├─sda1                8:1    0   1.4G  0 part 
├─sda2                8:2    0   100M  0 part 
├─sda3                8:3    0 451.9G  0 part 
├─sda4                8:4    0   518M  0 part 
├─sda5                8:5    0  11.9G  0 part 
├─sda6                8:6    0     1G  0 part 
└─sda7                8:7    0 457.9G  0 part 
  ├─fedora00-swap00 253:0    0   7.8G  0 lvm  
  ├─fedora00-home00 253:1    0   300G  0 lvm  
  └─fedora00-root00 253:2    0   150G  0 lvm  
zram0               252:0    0     8G  0 disk [SWAP]
nvme0n1             259:0    0 476.9G  0 disk 
├─nvme0n1p1         259:1    0   600M  0 part /boot/efi
├─nvme0n1p2         259:2    0     1G  0 part /boot
└─nvme0n1p3         259:3    0 475.4G  0 part /var/home
                                              /var
                                              /sysroot/ostree/deploy/fedora/var
                                              /usr
                                              /etc
                                              /
                                              /sysroot
$ rpm-ostree status
State: idle
Deployments:
● fedora:fedora/38/x86_64/silverblue
                  Version: 38.20230421.0 (2023-04-21T00:46:34Z)
               BaseCommit: 3cfd4aa4de1a4e47f2c607186408f22f1607bcfe4953311eea1e8f7c0c81e453
             GPGSignature: Valid signature by 6A51BBABBA3D5467B6171221809A8D7CEB10B464
          LayeredPackages: langpacks-en_GB

  fedora:fedora/38/x86_64/silverblue
                  Version: 38.20230420.0 (2023-04-20T03:26:13Z)
               BaseCommit: ac255bb74eb7ab97628e4bd4f0371af039d8495ed5fcef0ee9e9dccb01855436
             GPGSignature: Valid signature by 6A51BBABBA3D5467B6171221809A8D7CEB10B464
          LayeredPackages: langpacks-en_GB
travier commented 1 year ago

Where is /run/media/root/FA4A-9BC7 ? Can you give us the output of sudo blkid?

Naheem commented 1 year ago

Is this enough? I cant see anything mentioning the location of the /run/mmedia/root partition in the output.

The sd* partitions can be ignored - its an older install that I use for dumping data where I havent deleted the OS partitions... but this laptop is booting off the nvme drive

$ sudo blkid
/dev/mapper/fedora00-home00: UUID="bfef07da-e4d3-4e15-9ab0-6174c037c858" BLOCK_SIZE="4096" TYPE="ext4"
/dev/nvme0n1p3: LABEL="fedora_fedora" UUID="7e100a85-30de-4fdf-977d-9b4d5f3a9fd3" UUID_SUB="d30d9d20-6401-4430-9e54-5dd17cfd2573" BLOCK_SIZE="4096" TYPE="btrfs" PARTUUID="07438e48-28a3-4440-a149-79cbc49298d1"
/dev/nvme0n1p1: UUID="8229-0CA4" BLOCK_SIZE="512" TYPE="vfat" PARTLABEL="EFI System Partition" PARTUUID="3838856b-0f29-461c-8e6b-8ceb83ad0948"
/dev/nvme0n1p2: UUID="604c4958-cdd6-46f7-ac52-ae5c33de1acf" BLOCK_SIZE="4096" TYPE="ext4" PARTUUID="dc5230f5-3c2d-49c8-8f2d-bdcbcf81b211"
/dev/mapper/fedora00-root00: UUID="2d00f6ca-1c93-4444-b22a-a52496bbea98" BLOCK_SIZE="4096" TYPE="ext4"
/dev/mapper/fedora00-swap00: UUID="77f0599e-3362-4b0d-b46a-ef2becbe3310" TYPE="swap"
/dev/sda4: BLOCK_SIZE="512" UUID="D44E1F634E1F3DA4" TYPE="ntfs" PARTUUID="7e7414d5-ebca-40fb-9a09-84e0c92dd9cf"
/dev/sda2: SEC_TYPE="msdos" UUID="FA4A-9BC7" BLOCK_SIZE="512" TYPE="vfat" PARTLABEL="EFI System Partition" PARTUUID="9c33e39b-63fe-11e9-a418-9102b878c8f6"
/dev/sda7: UUID="5CcbvP-A8Px-npzV-v8LX-ydNq-aZQ2-PJUW3c" TYPE="LVM2_member" PARTUUID="c226482b-dcb5-48d6-8ba7-f6476d9a1ca5"
/dev/sda5: LABEL="Lenovo_Recovery" BLOCK_SIZE="512" UUID="CAF8F576F8F560DD" TYPE="ntfs" PARTUUID="9c33e39d-63fe-11e9-a418-9102b878c8f6"
/dev/sda3: LABEL="Windows7_OS" BLOCK_SIZE="512" UUID="1000D26E00D25A74" TYPE="ntfs" PARTUUID="9c33e39c-63fe-11e9-a418-9102b878c8f6"
/dev/sda1: LABEL="SYSTEM_DRV" BLOCK_SIZE="512" UUID="0638CF4B38CF3887" TYPE="ntfs" PARTUUID="9c33e39a-63fe-11e9-a418-9102b878c8f6"
/dev/sda6: UUID="2b403a77-dff1-4aeb-89fb-f9053282e2f0" BLOCK_SIZE="4096" TYPE="ext4" PARTUUID="3214bcb2-b4dd-48f2-b5c1-1a7b93cdd342"
/dev/zram0: LABEL="zram0" UUID="384f071b-cbe9-4c06-b40b-fa0aaaeb5452" TYPE="swap"
travier commented 1 year ago
/dev/sda2: SEC_TYPE="msdos" UUID="FA4A-9BC7" BLOCK_SIZE="512" TYPE="vfat" PARTLABEL="EFI System Partition" PARTUUID="9c33e39b-63fe-11e9-a418-9102b878c8f6"

fwupd is confused because your have 2 EFI / ESP partition and it's looking at the "wrong" one.

travier commented 1 year ago

Or maybe it's not the wrong one and it's the one you're using to boot your system? It's unclear.

Naheem commented 1 year ago

I deleted the sda2 EFI partition and now, the firmware does decompress so it does seem like fwupdmgr was being confused about the correct EFI partition.

However when rebooting, it still does not apply the update.

travier commented 7 months ago

Can you reproduce this with Fedora 40? Thanks

Naheem commented 6 months ago

I dont have any outstanding firmare updates so I am unsure how to check.

if you can put instructions here, I can test them, or otherwise this can be closed.

travier commented 6 months ago

This is something to ask to the fwupd folks. In the mean time, I'll close this one. We can re-open it if someone can re-produce it.