search

fedora-sysv / initscripts

📜 Scripts to bring up network interfaces and legacy utilities in Fedora.
GNU General Public License v2.0
46 stars 52 forks source link

maintain permission #327

Closed zhangnaru0605 closed 4 years ago

zhangnaru0605 commented 4 years ago

set umask in case resolv.conf doesn't exist

jamacku commented 4 years ago

Thank you for your contribution. This patch make sense to me. There is only one small thing, could you please change umask $oldumask to umask "$oldumask". Thank you.

zhangnaru0605 commented 4 years ago

update maintain permission: change umask $oldumask to umask "$oldumask"

jamacku commented 4 years ago

Thank you.

zhangnaru0605 commented 4 years ago

Hello, could you please review my commit again, due to my misoperation, the Review is requied, thank you!

jamacku commented 4 years ago

@zhangnaru0605, thank you for your contribution. Could you please squash your commits into one and force push it. Thank you.

zhangnaru0605 commented 4 years ago

@jamacku , I will close this PR and commit new one ,thank you!