search

fedora-sysv / initscripts

📜 Scripts to bring up network interfaces and legacy utilities in Fedora.
GNU General Public License v2.0
46 stars 51 forks source link

Add optional 'dev' keyword #334

Closed jamacku closed 4 years ago

jamacku commented 4 years ago

Fix the problem when the device name could be interpreted as an iproute2 keyword. For example, for a bridge slave named "a" the iproute2 would treat the name as a prefix of keyword "address" and the network-scripts would fail to set the bridge master.

Related: rhbz #1859785

jamacku commented 4 years ago

@msekletar, Could you please review this. Thank you.

msekletar commented 4 years ago

LGTM, however the commit message is very vague (specifically part Specific device names could be misinterpreted as something else) so I had to look up some details in the corresponding BZ.

msekletar commented 4 years ago

Suggestion for better commit message (based on BZ problem description)

Add optional 'dev' keyword

Fix the problem when the device name could be interpreted as an iproute2 keyword. For example, for a bridge slave named "a" the iproute2 would treat the name as a prefix of keyword "address" and the network-scripts would fail to set the bridge master.

jamacku commented 4 years ago

Thank you @msekletar.