fedora-sysv / initscripts

📜 Scripts to bring up network interfaces and legacy utilities in Fedora.
GNU General Public License v2.0
46 stars 51 forks source link

remove rename_device_lock when process does not exist #360

Closed wangxp006 closed 3 years ago

wangxp006 commented 3 years ago

if rename_device is killed during fopen period in take_lock ,LOCKFILE will not be remove in sighandler. Excute rename_device again, LOCKFILE is exist ,but the process with pid in LOCKFILE is not running, take_lock will never return. Resolves: #1916545

jamacku commented 3 years ago

Hello, Every patch for rhel8-branch need to have corresponding Bugzilla bugs attached to them in order to get them into RHEL 8.

So I would like to kindly ask you If you could create new RHEL8 Bugzilla bug at https://bugzilla.redhat.com/

Thank you

wangxp006 commented 3 years ago

Hello, Every patch for rhel8-branch need to have corresponding Bugzilla bugs attached to them in order to get them into RHEL 8.

So I would like to kindly ask you If you could create new RHEL8 Bugzilla bug at https://bugzilla.redhat.com/

Thank you

HI @jamacku , I have report the bug in bugzilla 。 https://bugzilla.redhat.com/show_bug.cgi?id=1916545

If there is any problem, please let me know.

jamacku commented 3 years ago

Hi @wangxp006 , Thank you for Bugzilla report.

One last think is missing. Could you please add Resolves: #1916545 into commit message. (example: 20d36a2f6eac761b21f6fbc48a42ffd5c1d2c42c)

Thank you for your cooperation, Jan

wangxp006 commented 3 years ago

I will close this PR, and submit another one