search

fedora-sysv / initscripts

📜 Scripts to bring up network interfaces and legacy utilities in Fedora.
GNU General Public License v2.0
45 stars 51 forks source link

When bond4 negotiation is not complete, the ifup script arping fails and the error information is misleading. #465

Open lbo874 opened 7 months ago

lbo874 commented 7 months ago

I run the ifup script while the bond4 negotiation process is running and not finished. The arping command fails to be executed. The command output is as follows: image

Obviously, the up failure is not caused by an IP address conflict. I think such an error is misleading. image https://github.com/fedora-sysv/initscripts/blob/32f0ddf2efb7e02227febca5c43acae36a52f569/network-scripts/ifup-eth#L296C11-L296C11 Whether this can be optimized. You can correct the up error information based on the arping command output, or try again in this case.

lnykryn commented 7 months ago

Yeah, that part of the code is .... suboptimal. It is already stupid that we call some random sed on the output (and yeah I know it was my code). In the ideal case, we should find out if arping returns different return codes on different events and base the behavior on that. But to be honest, initscripts are no longer actively developed and almost nobody is using the network part these days, so this is not a priority for us. But I would be happy to review any patch to improve this.

lnykryn commented 7 months ago

In your case, it might be enough to set ARPING_WAIT to some higher value in the ifcfg file.