search

fedora-sysv / initscripts

📜 Scripts to bring up network interfaces and legacy utilities in Fedora.
GNU General Public License v2.0
47 stars 52 forks source link

retry arping one more time in ifup-eth when sendto failed #490

Open xanoxes opened 1 month ago

xanoxes commented 1 month ago

retry arping one more time in ifup-eth when sendto failed

lnykryn commented 1 month ago

Honestly, I don't like the "try things again if they fail" approach. It is not a sign of good design. But the network-scripts always had ton of hacks, so I am probably fine with adding one.

But please try to do this a bit nicer; copying a code and putting it in else close under is ugly as hell. What I could imagine is a new ARPING_RETRY or ARPING_TRIES option and then looping over arping until the limit is hit. And this would also allow not to change the behaviour and keep this opt-in.

xanoxes commented 4 weeks ago

You're right, its ugly. So i refactor it with ARPING_TRIES. Please review this PR again.

lnykryn commented 4 weeks ago

And please squash your commits.

xanoxes commented 2 weeks ago

@lnykryn