Ui modal updates - Githubissues

fedordead / vanilla-ui

Plain vanilla UI components written in ES6. Nothing artificial, all organic!

MIT License

6 stars 2 forks source link

Closed DaveOrDead closed 8 years ago

DaveOrDead commented 8 years ago

This is a big of a biggie. Main changes are

Added docblock style comments to all functions
Added utils for querySelectorAll and defer
Added aria-controls and id properties to html elements which are used to identify which modal to open
Now attaches event listeners to all instances with the same js hook rather than just the first found
Some really basic a11y
Return focus to launch button after close

There are still a few bugs, but I didn't want to get too far into it

modal

chris-pearce commented 8 years ago

The reason for my really short—basically rude—style of commentary is because I was going through the PR with @DaveOrDead on Skype 😄.

@DaveOrDead I'll create some GH Issues for things we spoke about.