fedorov / MultiVolumeImporter

A 3D Slicer module to support import of multi-volume data from non-DICOM sources, and provide plugin for importing such data from images saved in DICOM.
http://wiki.slicer.org/slicerWiki/index.php/Documentation/Nightly/Modules/MultiVolumeImporter
Other
9 stars 25 forks source link

Add support for loading into sequence node and other improvements #24

Closed lassoan closed 7 years ago

lassoan commented 7 years ago

Main feature is to allow reading of volume sequences into Sequence nodes. User preference can be defined in Application Settings (by default, it is multi-volume).

Several improvements and fixes have been made to make loading time shorter and give feedback about the progress to the user during loading.

fedorov commented 7 years ago

Thank you Andras! I will review/test shortly.

lassoan commented 7 years ago

I've just tested, and even though I have "volume sequence" set as preferred, I still only see the MultiVolume node in the loadables list

Do you have Sequences extension installed?

lassoan commented 7 years ago

I think it would be nice to initialize those consistently with the multivolume nodes

I agree. Would you be able to make that change? Index name and unit are just simple strings. Name refers to the quantity (e.g., "time"). Unit refers to the measurement unit (e.g., "sec").

lassoan commented 7 years ago

do you know if change of those settings require Slicer restart? I was not notified that it is required. I did try restarting, but it didn't change the behavior.

No need to restart Slicer for this, just click Examine button again.

fedorov commented 7 years ago

Do you have Sequences extension installed?

I did not! It works now - very nice!

What do you think about checking if Sequences is installed at the time user changes the multivolume preferred import format, and notifies the user that Sequences should be installed if that format is selected, but Sequences is not installed?

Index name and unit are just simple strings.

Can you specify the actual index values for the individual frames in Sequences, not just the quantity?

lassoan commented 7 years ago

Can you specify the actual index values for the individual frames in Sequences, not just the quantity?

Yes, you just need to update this line:

indexValue = str(frameNumber)
lassoan commented 7 years ago

What do you think about checking if Sequences is installed at the time user changes the multivolume preferred import format, and notifies the user that Sequences should be installed if that format is selected, but Sequences is not installed?

Good idea. I would work on that after the rest has been integrated.

lassoan commented 7 years ago

Is there anything I should do to get this integrated?

fedorov commented 7 years ago

No, I just didn't find time to add the feature we discussed.

lassoan commented 7 years ago

Thank you!

fedorov commented 7 years ago

Thank you for your contribution!