search

fedorov / imagingdatacommons.github.io

[retired] Home page of the IDC consortium
https://imagingdatacommons.github.io
MIT License
0 stars 1 forks source link

Favicon change #2

Closed s-paquette closed 4 years ago

s-paquette commented 4 years ago

Replace default favicon with IDC-logo favicon (32x32 transparent PNG)

fedorov commented 4 years ago

Could you also update all of the icons in that folder? My guess those are for website shortcuts for mobile?

s-paquette commented 4 years ago

Oh that's probably true. Sure thing.

fedorov commented 4 years ago

I used this as an opportunity to check connecting this repo to our ZenHub workspace ... interesting, but not quite what I wanted ... Should review this later at some point.

I guess the most useful thing is that we can connect PRs/issues from other repos under the org to Epics in the management repo (which is what I did), may help organize things.

s-paquette commented 4 years ago

Added the rest - @fedorov how's that look?

s-paquette commented 4 years ago

Note, we might want to adjust this because if someone is using a dark theme a transparent favicon may not look so great--I have an appt to run to shortly but when I can get back I'll look at some options eg. with a pale drop-shadow/glow which would disappear on a light theme and let it show up on a dark one, and you can see if you'd prefer that. (Or I can just put them on a white background, of course.)

fedorov commented 4 years ago

Great, thank you! I will create an issue for the dark theme, so we don't forget.

fedorov commented 4 years ago

@s-paquette don't know why, but the favicon update does not show up (tested in Chrome Incognito)

image

s-paquette commented 4 years ago

Possibly a cache issue--does empty cache hard reload work?

fedorov commented 4 years ago

I tested in incognito for that specific reason - I thought I should not have any cookies/caching, no?

fedorov commented 4 years ago

anyway, this is not a high priority issue, I was just hoping it can be resolved quickly. If not, can address later.

fedorov commented 4 years ago

No idea what was going on, I probably misunderstand how favicon caching and chrome incognito work together, but I just noticed it is working now! All set!