fedspendingtransparency / fedspendingtransparency.github.io

Federal Spending Transparency
http://fedspendingtransparency.github.io
Creative Commons Zero v1.0 Universal
54 stars 118 forks source link

DAIMS Taxonomy element review feedback #154

Open dataact opened 8 years ago

dataact commented 8 years ago

Hello, I have reviewed DAIMS v1.0 and have some observations. 1) Award Modification or Amendment Identifier By the instruction (defined as instruction typed label in the taxonomy), for initial award, inputting "0" is instructed, however users cannot input "0" because of its data type (positiveIntegerItemType).

2) Ward Recipient Legal Entity US ZIPS The element for US ZIP code such as 10017, but data type is positiveIntegerItemType, this should be a string-based data type

3) Awarding Agency Code (CGAC) This is also positiveInteger type, however the element for Funding Office Code (CGAC) is string-based type, for the nature of the element to capture the identification of Angecy, this should be string-based type (or no type like Funding Office Code (CGAC)).

4) Transaction Sub-key Number The nature of the element is an identification, this should be string-based type like other identification number.

DATAActPMO commented 8 years ago

Thank you for your feedback. We have reviewed your comments and we will make adjustments at the next opportunity.