search

fedspendingtransparency / usaspending-api

Server application to serve U.S. federal spending data via a RESTful API
https://www.usaspending.gov
Creative Commons Zero v1.0 Universal
310 stars 113 forks source link

[DEV-10812] Filters in Txn Count Endpoint #4082

Closed ghost closed 6 months ago

ghost commented 6 months ago

Description: The /api/v2/search/spending_by_transaction_count/ only currently supports the keywords filter. It should be updated to support all the filters supported by /api/v2/search/spending_by_transaction/. That ask, is implemented by this PR>

Requirements for PR merge:

  1. [x] Unit & integration tests updated
  2. [x] API documentation updated
  3. [ ] Necessary PR reviewers:
    • [ ] Backend
    • [x] Frontend (N/A)
    • [x] Operations (N/A)
    • [x] Domain Expert (N/A)
  4. [x] Matview impact assessment completed (N/A)
  5. [x] Frontend impact assessment completed (N/A)
  6. [x] Data validation completed
  7. [x] Appropriate Operations ticket(s) created
  8. [x] Jira Ticket DEV-10812:
    • [x] Link to this Pull-Request
    • [x] Performance evaluation of affected (API | Script | Download)
    • [x] Before / After data comparison

Area for explaining above N/A when needed: 3b, 3c, 3d The nature of this work does not require PR reviews from these groups

  1. The nature of this work does not impact materialized views
  2. The nature of this work does not require an impact assessment from the frontend