search

fedspendingtransparency / usaspending-api

Server application to serve U.S. federal spending data via a RESTful API
https://www.usaspending.gov
Creative Commons Zero v1.0 Universal
310 stars 113 forks source link

[DEV-11067] Updates to Bureau Title Lookup Loader #4107

Closed collinwr closed 5 months ago

collinwr commented 5 months ago

Description:

  1. Updates logic to exclude records with an agency ID of 999
  2. Wraps command in a transaction to ensure that failing commands don't leave bureau_title_lookup table empty
  3. Updates unit tests to cover more scenarios (1 and 2 above)

Requirements for PR merge:

  1. [x] Unit & integration tests updated
  2. N/A API documentation updated
  3. [ ] Necessary PR reviewers:
    • [ ] Backend
  4. [x] Matview impact assessment completed
  5. [x] Frontend impact assessment completed
  6. [x] Data validation completed
  7. N/A Appropriate Operations ticket(s) created
  8. [ ] Jira Ticket DEV-11067:
    • [x] Link to this Pull-Request
    • N/A Performance evaluation of affected (API | Script | Download)
    • [x] Before / After data comparison

Area for explaining above N/A when needed: