fedspendingtransparency / usaspending-api

Server application to serve U.S. federal spending data via a RESTful API
https://www.usaspending.gov
Creative Commons Zero v1.0 Universal
309 stars 112 forks source link

[DEV-11187] Fixes issue loading from CONFIG instead of settings #4146

Closed collinwr closed 3 months ago

collinwr commented 3 months ago

Description: Incorrectly reading some settings in our download helpers. This PR fixes the problem

Requirements for PR merge:

  1. [x] Unit & integration tests updated
  2. [x] API documentation updated
  3. [ ] Necessary PR reviewers:
    • [ ] Backend
  4. [x] Matview impact assessment completed
  5. [x] Frontend impact assessment completed
  6. [x] Data validation completed
  7. N/A - Appropriate Operations ticket(s) created
  8. [x] Jira Ticket DEV-11187:
    • [x] Link to this Pull-Request
    • N/A - Performance evaluation of affected (API | Script | Download)
    • N/A - Before / After data comparison

Area for explaining above N/A when needed: