search

fedspendingtransparency / usaspending-api

Server application to serve U.S. federal spending data via a RESTful API
https://www.usaspending.gov
Creative Commons Zero v1.0 Universal
308 stars 109 forks source link

[DEV-11405]: Updating API Endpoint Logic #4175

Closed LKambhampati-frb closed 2 months ago

LKambhampati-frb commented 2 months ago

Description: DEV-10991: Updates to Spending by Subagency Endpoints made updates to two Spending by Subagency Endpoints. After implementation, it was discovered that the updates did not fully meet the frontend needs, so some additional changes are necessary.

Requirements for PR merge:

  1. [x] Unit & integration tests updated
  2. [x] API documentation updated
  3. [x] Necessary PR reviewers:
    • [ ] Backend
    • [x] Frontend (N/A)
    • [x] Operations (N/A)
    • [x] Domain Expert (N/A)
  4. [x] Matview impact assessment completed (N/A)
  5. [x] Frontend impact assessment completed (N/A)
  6. [x] Data validation completed
  7. [x] Appropriate Operations ticket(s) created
  8. [x] Jira Ticket DEV-11405:
    • [x] Link to this Pull-Request
    • [x] Performance evaluation of affected (API | Script | Download)
    • [x] Before / After data comparison

Area for explaining above N/A when needed: 3b, 3c, 3d The nature of this work does not require PR reviews from these groups

  1. The nature of this work does not impact materialized views
  2. The nature of this work does not require an impact assessment from the frontend