search

fedspendingtransparency / usaspending-api

Server application to serve U.S. federal spending data via a RESTful API
https://www.usaspending.gov
Creative Commons Zero v1.0 Universal
310 stars 113 forks source link

[DEV-11088] Update disaster endpoint calculations #4220

Closed sethstoudenmier closed 2 weeks ago

sethstoudenmier commented 2 weeks ago

Description: Updates to the total_spending endpoints to take into account the new PYA values.

Technical details:

The new PYA columns were moved into the disaster base class in an attempt to normalize the columns across the different implementations and better explain their use / intention. Only the total_spending endpoints were updated that use File B data.

Additionally, a change to the .pre-commit-config.yaml was made to support its use as I ran into a bug that prevent me from committing code when using pre-commit without this change.

Requirements for PR merge:

  1. [x] Unit & integration tests updated
  2. [x] API documentation updated
  3. [x] Necessary PR reviewers:
    • [x] Backend
  4. [x] Matview impact assessment completed
  5. [x] Frontend impact assessment completed
  6. [x] Data validation completed
  7. [x] Appropriate Operations ticket(s) created
  8. [x] Jira Ticket DEV-11088:
    • [x] Link to this Pull-Request
    • [x] Performance evaluation of affected (API | Script | Download)
    • [x] Before / After data comparison

Area for explaining above N/A when needed: