search

feduxorg / proxy_pac_rb

proxy_pac _rb is a gem to test, compress, lint, and parse proxy auto-config files
https://github.com/fedux-org/proxy_pac_rb
MIT License
3 stars 2 forks source link

Rails5.1 #3

Closed net1957 closed 7 years ago

net1957 commented 7 years ago

this pull request address #2 All tests are green and my test on a little rails 5.1 application are OK. I did test it on a vagrant box ''ubuntu/trusty64' with ruby 2.3

I did generate a .rubocop_todo.yml file to avoid changing lots of files without knowing your coding style. I'm not very familiar with pull request, so I would appreciate every comment or modification.

net1957 commented 7 years ago

Can you help on those failures ?

maxmeyer commented 7 years ago

@net1957 Would you mind to split this into two PRs? One for bumping versions and one for "the rest".

maxmeyer commented 7 years ago

Sorry for the late reply. I oversaw that PR. Best is to use @maxmeyer into PRs. That way I see it in my participating list. I really want to see this fixed. So thanks for helping out.