fedwiki / wiki-plugin-plugmatic

Administer Installed Plugins
2 stars 3 forks source link

Missing error handling... #7

Closed paul90 closed 6 years ago

paul90 commented 6 years ago

On start-up the plugin makes a request to github

https://github.com/WardCunningham/wiki-plugin-plugmatic/blob/83b1c99199b3fe7339f0d8dacbb385ae393bdaf4/server/server.coffee#L33

There appears to be no error handling, which might be causing the problem seen in fedwiki/wiki#112

As an aside, this will be performed for each wiki in a farm as it starts - this sort of admin plugin would probably be better served with a per farm component, rather than per wiki.

WardCunningham commented 6 years ago

I will make this request on demand, once for each app running on a server. And I will handle errors by just not making the data available to the client which will have to tolerate that circumstance by leaving the package column blank.

WardCunningham commented 6 years ago

Resolved by #8.