search

fedwiki / wiki-plugin-video

Embed Video from YouTube or Vimeo
Other
3 stars 5 forks source link

Clicking on video item doesn't open editor. #6

Closed cpjobling closed 9 years ago

cpjobling commented 9 years ago

I have discovered an issue with the video plugin. When I used the video plugin, I found that I could not click to edit even if I added a caption as suggested in Add Videos.

This caused two issues:

  1. I couldn't remove a badly formed video element and
  2. I couldn't edit an embedded YouTube video to change its dimensions.

I had to resort to editing the wiki page using vim which I assume means that the page history is incorrect.

A couple of comments:

  1. if this is a bug, can it be easily fixed?
  2. Would you consider adding an edit button to items to work around the vagaries of click handlers on divs?

I have tested this issue with this page: http://journal.wiki.cpjobling.me/view/welcome-visitors/view/crispy-journal/view/what-happens-when-i-click-a-link on

All on a Macbook Pro running OSX 10.10.1 ("Yosemite").

paul90 commented 9 years ago

Thanks @cpjobling - Spotted this last night while adding the Hyperland video.

This is fixed in #7 which undoes the change that applies some spacing around the video - there is an associated client update to add the spacing via the main css file.

cpjobling commented 9 years ago

Great! I'm running from the NPM package so I guess I'll get the fix when the next release comes out. If I can't wait, are there any tips on how I might install the wiki package from the GitHub HEAD so that I can track and contribute to the project.

I'm set up using Mike Caulfield's installation guidelines on a DigitalOcean droplet.

WardCunningham commented 9 years ago

@paul90 If wiki-plugin-video were updated in npm, wouldn't @cpjobling just go to the Digital Ocean console and type, npm install -g wiki-plugin-video? No server restart required?

paul90 commented 9 years ago

Installing from git will not work, as the generated javascript does not get uploaded.

The wiki is installed in /usr/local/lib/node_modules/wiki, so it will just be a matter of running npm install wiki-plugin-video there. But, give me a moment to get it rebuilt / tested / and published.

paul90 commented 9 years ago

@cpjobling @WardCunningham - updated published as + wiki-plugin-video@0.2.1

To update the plugin, if using the DigitalOcean install, you will need to be in /usr/local/lib/node_modules/wiki and run npm install wiki-plugin-video. The install should tell you that it has installed version 0.2.1.

There is no need to restart the server, just reload the client to load the updated plugin.