Recycle pages being removed

fedwiki / wiki-server

Federated Wiki client and server in Node.js

Other

153 stars 35 forks source link

Recycle pages being removed #133

Closed paul90 closed 6 years ago

paul90 commented 7 years ago

Work in progress, see related client update fedwiki/wiki-client#197.

WardCunningham commented 7 years ago

I wonder if there are any risks associated with merging this in advance of through testing of the corresponding client side? We would want to be sure that deletes come from logged in users.

paul90 commented 7 years ago

I think it is probably best holding off until we are ready to merge the client as well. There are also a few more changes that are need here as well.

WardCunningham commented 6 years ago

Looks promising. Could handle DELETE too, for that most final of deletes.

Safe Delete:

retrieve create version
fork it (interpreted as DELETE)

Recycler Delete:

retrieve original from recycler
retrieve create version
fork it (interpreted as recycler DELETE)

Two steps to hid from public, five to make page vanish.

paul90 commented 6 years ago

Delete from recycler is not committed yet - holding off while I finalize the recycler plug-in that brings this together.

paul90 commented 6 years ago

Recycler Delete:

retrieve original from recycler

retrieve create version

fork it (interpreted as recycler DELETE)

Currently I am using a recycler plug-in, that lists the pages in the recycler, each has a delete button and there is an 'empty recycler' button. So, only two steps to delete from recycler.

open page with recycler plugin
press the delete button that's beside the page

Retrieving page from recycler is three steps

open page with recycler plugin
open page from the recycler
fork it - this will swap the page in the recycler with the copy in the site, if there is one

WardCunningham commented 6 years ago

I'm liking the way this is going and look forward to a demo.