Remove assumption about where wiki-client gets installed on disk

fedwiki / wiki-server

Federated Wiki client and server in Node.js

Other

153 stars 35 forks source link

Remove assumption about where wiki-client gets installed on disk #148

Closed dobbs closed 4 years ago

dobbs commented 5 years ago

Use require.resolve() to find the location on disk.

~Depends on https://github.com/fedwiki/wiki-client/pull/245~

Motivation for the change:

Wiki previously assumed the locations of wiki-client and wiki-server within node_modules. Glitch.com uses pnpm to install node modules. It organizes the filesystem differently than wiki-server expected.

This change lets node's resolution tell us where the wiki-client is installed.

I think this is a better solution than #147

dobbs commented 5 years ago

I've installed this branch with the corresponding changes in https://github.com/fedwiki/wiki-client/pull/245 over here: https://great-hat.glitch.me