search

fedwiki / wiki-server

Federated Wiki client and server in Node.js
Other
153 stars 35 forks source link

wiki-storage-couchdb #75

Closed lenada closed 9 years ago

lenada commented 9 years ago

I added CouchDB storage for wiki. it currently lives here https://github.com/wesrc/wiki-storage-couchdb

WardCunningham commented 9 years ago

@lenada Its great to have couchdb included among our storage modules. Thank you.

If you would like to contribute this to the fedwiki github organization then it would make sense for us to fork your repo, publish an npm module, and update the datastore options in the readme. github

I will defer to @paul90 regarding details. We would hope you would match the dual licenses were using in the rest of this codebase: mit & gpl.

lenada commented 9 years ago

@WardCunningham yes, please fork to fedwiki and publish on npm :+1:

We would hope you would match the dual licenses were using in the rest of this codebase: mit & gpl.

thats fine! license files already live in the repo.

I was not 100% sure how to run the tests. Copying the testcase into wiki-server (as described in the readme of other storage modules) is a bit of a hassle. I ended up requiring server & client as dependencies for the package. Now the (integration) tests can be run just for the storage-couchdb repo (for example on travis-ci Build Status)

Maybe you and @paul90 can give some feedback how testing for the wiki-storage-* modules can be streamlined and ideally separated from wiki-server/test?

paul90 commented 9 years ago

It has been forked to fedwiki, and publish on npm as + wiki-storage-couchdb@0.0.1

@lenada do you have an npm account? If so I will add you to the list of maintainers there.

As package.json points issues in fedwiki/wiki-storage-couchdb repository I have enabled issues there. This may or may not make sense.

Maybe you and @paul90 can give some feedback how testing for the wiki-storage-* modules can be streamlined and ideally separated from wiki-server/test?

The approach you are taking seems fine. It would make sense to change the other modules to do it the same way - I forget now why it was done the way it was.

lenada commented 9 years ago

do you have an npm account?

@paul90 I don't have one yet - and currently npmjs.org registration seems broken ;) I'll let you know once I am signed up