search

fedwiki / wiki-server

Federated Wiki client and server in Node.js
Other
153 stars 35 forks source link

2 sitemap tests #87

Closed paul90 closed 9 years ago

paul90 commented 9 years ago

The put tests fail without these as the test server does not create a sitemap when it starts.

WardCunningham commented 9 years ago

I have to admit that I don't completely understand this test runner. Do our tests depend on running in sequence? That's ok with me but some idealists will complain.

I do see the failures and they do go away with this commit.

paul90 commented 9 years ago

More that the way the before action for these test does not call createSitemap - so it can't save a reference to the pagehandler, so when the 'should create a page' test is called it fails as the pagehandler is null. An alternative might have been to just create an empty sitemap.json file...

paul90 commented 9 years ago

Published as part of + wiki-server@0.5.1