search

fedwiki / wiki-server

Federated Wiki client and server in Node.js
Other
153 stars 35 forks source link

make factory.json static #92

Closed paul90 closed 9 years ago

paul90 commented 9 years ago

create a static version of factory.json

The client fetches this file once for each instance of the factory plugin. This probably could be considered to be a client fault, but lets make it cacheable, so there is the possibility of it being fetched only when it has been updated.

WardCunningham commented 9 years ago

Hmm. The factory plugin is trying to cache this in a global called window.catalog. https://github.com/fedwiki/wiki-client/blob/master/lib/factory.coffee#L47-L52

I suspect this logic fails by the async retrievial problem we've seen before when the first page has multiple factories as Welcome Visitors does.

WardCunningham commented 9 years ago

But wait, the factories in Welcome Visitors don't show the menu since those factories have prompts. I wonder how it is you are seeing multiple fetches of factories.json?

(I'm not doubting that a busy farm won't be doing lots of extra work by not caching server side but I am worried that we've not noticed a regression in behavior that once worked ok.)

paul90 commented 9 years ago

I suspect this logic fails by the async retrievial problem we've seen before when the first page has multiple factories as Welcome Visitors does.

That is almost certainly it - will close this.