feedbin / support

83 stars 11 forks source link

Feedbin parses link tags too aggressively? #109

Open jyruzicka opened 11 years ago

jyruzicka commented 11 years ago

If an RSS item has a link of the form:

http://www.foo.com/action?param=key&redirect=http%3A%2F%2Fwww.foo.com%2FanotherAction%3Fparam%3Dvalue%26param2%3Dvalue2

The resultant link should be to:

http://www.foo.com/action?param=key&redirect=http%3A%2F%2Fwww.foo.com%2FanotherAction%3Fparam%3Dvalue%26param2%3Dvalue2

i.e. the reader shouldn't parse %xx-style characters. In practice, it will instead give you the following link:

http://www.foo.com/action?param=key&redirect=http://www.foo.com/anotherAction?param=value&param2=value2

This means that the redirect parameter is now read as http://www.foo.com/anotherAction?param=value.

It seems like Feedbin shouldn't be parsing the %xx characters, leaving that up to the browser when I click the link on the item.

Zegnat commented 11 years ago

Side note: probably related to the discussion in #95: Addressible doesn’t seem to recognise query parameters.