feedbin / support

83 stars 11 forks source link

Chrome activity indicator going off too often #356

Closed eliahhecht closed 11 years ago

eliahhecht commented 11 years ago

In Chrome, background tabs get a glow when there's some activity on the page, to let you know something new has happened and you should go check the tab. Feedbin's tab does this way too often -- I'm guessing every time it polls the server to see if there are new stories. I would expect the activity indicator to only light up if there really are new stories for me to read.

Not sure what the fix is, because I don't know exactly how Chrome decides when to light up the tab. I thought it was just when the title changed, but it doesn't look like the title of the Feedbin tab is changing during poll.

Here's a screenshot of what I'm talking about; you can barely see the glow on the pinned Feedbin tab: image

Edit: It looks like this can happen if the title of the tab is re-set to what it already was. If Feedbin is doing this every time it fetches and finds no new stories (maybe at https://github.com/feedbin/feedbin/blob/master/app/assets/javascripts/_site.js.coffee#L138), that would explain the issue.

Zegnat commented 11 years ago

Looks like line 144 is the actual problem, always changing the title. I can’t make a pull request now, but replacing that with something like this should fix it:

docTitle = $('title')
docTitle.text(title) unless docTitle.text() is title
benubois commented 11 years ago

Should be fixed now. feedbin/feedbin#31