search

feedbin / support

83 stars 11 forks source link

"Include all X feeds matching this search" applies action to ALL subscriptions, not just the search results. #593

Closed dotHTM closed 5 years ago

dotHTM commented 5 years ago

Background

I've recently been playing with the API, seeing what little scripts I can put together for helping me organize my feeds.

After a while, I decided I had imported too many things, and being they were all from a common domain, I went to the Subscriptions tool, did a search for that domain, checked the "Include all X feeds matching this search" and selected the action "Unsubscribe".

To my surprise, ALL my subscriptions had been unsubscribed!

Thankfully I had just downloaded a backup of my feeds before I started coding anything.

This seems to affect all the actions under that list, and I assume what's meant to open the action to the full list of results ends up instead being opened up to the full set of subscriptions (regardless of the search result).

Steps to reproduce

Before I begin these tests, I make sure all subscriptions are NOT muted, using the Action dropdown and spot checking results near the top of the list. I currently have 900+ subscriptions, so it's unlikely that "Include all 244 feeds..." applies to those that I intuit to not be in the results list.

  1. When using the Feedbin website, I click the "hamburger" menu and click Subscriptions
  2. I enter a search for "youtube.com", and the list updates to show those subscriptions. There are multiple pages of results.
  3. I click the checkbox next to "Actions"
  4. A new checkbox appears that reads "Include all 244 feeds matching this search". Click this checkbox to enable.
  5. I click the Actions dropdown, and select Mute
  6. Check some of the subscriptions that should not have matched the search result, they are set to be muted.

Expected result:

Subscriptions from "youtube.com" are set to mute.

All other subscriptions are set to NOT mute.

Actual Results:

ALL subscriptions are set to mute.

Note

Leaving the "Include all X feeds matching this search" checkbox disabled only affects the current page, and search results that are contained in a single results page are unaffected by this bug.

For this bug to show, the search result MUST be more than one page, and the "Include all X feeds matching this search" MUST be enabled.

benubois commented 5 years ago

Ouch, that's pretty bad :/ Should be fixed now.

Thanks for reporting this and for providing so much detail!