RSS feed: MacRumors – broken images

feedbin / support

83 stars 11 forks source link

RSS feed: MacRumors – broken images #609

Closed rauschma closed 4 years ago

rauschma commented 4 years ago

Feed URL: http://www.macrumors.com/macrumors.xml
Gist with files: https://gist.github.com/rauschma/96a99d6b929b25739c0fd006d4ec464a
Tip: The curl options should include --location (i.e., -svL) so that feeds are also downloaded if there are redirects.

Problem – images are not shown: feedbin-macrumors

benubois commented 4 years ago

Thanks for reporting this! MacRumors is dynamically serving webp images based on the Accept header.

Looks like Feedbin's image proxy CDN was ignoring Accept in the cache key so it was sometimes serving a webp image to a browser that didn't support it.

Should be fixed now, though you will probably have to clear your browser cache to see it on articles you have already viewed.

rauschma commented 4 years ago

Interesting! Thanks for the fix.

rauschma commented 4 years ago

Alas, there are still occasionally images missing (Safari).

benubois commented 4 years ago

I feel like this was working for a bit after the last change? Am I crazy?

Anyway, now I've turned off passing Accept headers upstream so everyone gets image/jpeg.

Again, you'll need to clear your cache to see images on already viewed articles. Surprised Safari caches Content-Types it doesn't understand. Or not. I don't know how browsers work.

rauschma commented 4 years ago

It looks like this did the trick.

AFAICT, the previous fix worked for some entries, but not for all of them.