search

feederbox826 / stash-s6

stashapp/stash docker rewrite
https://github.com/stashapp/stash/issues/4300
GNU Affero General Public License v3.0
17 stars 2 forks source link

plugin requirements are not getting installed #15

Closed TheGlitchGal closed 1 month ago

TheGlitchGal commented 1 month ago

the entrypoint script does not properly install plugin requirements

the culprit is [ -s ... ] || [ ! -f ... ] (entrypoint.sh:255)

the expr translates roughly to "(exists and not empty) or not exists"; so any requirement collection done previously which results in a non empty requirements file, will make [ -s ... ] pass and the default requirements file gets copied over.

I assume the goal was "not exists or empty", so i propose [ ! -f ... ] || [ ! -s ... ]

I'll sketch-up a PR in a moment

feederbox826 commented 1 month ago

Thanks! My bash-isms are lacking and it shows...

TheGlitchGal commented 1 month ago

such an icky little typo can easily happen to anyone pretty fast :joy: