feedhenry-templates / fh-api-mapper

API Mapping Tool

Apache License 2.0

8 stars 12 forks source link

Rhmap 4350 #68

Closed pb82 closed 8 years ago

pb82 commented 8 years ago

Motivation

Create a new PR from this one: https://github.com/feedhenry-templates/fh-api-mapper/pull/49 (don't want to rebase and force push into Cian's repo). Also added version bump.

Added a test, fixed the requester tests and removed tests that do not make sense when requester is mocked out.

ping @wei-lee

mmurphy commented 8 years ago

looks ok, adding a unit test for headersToRequestFormat to fh-api-mapper/test/unit/test-lib-requester.js would be good though, even if it's just testing upper/lowercase header values.

pb82 commented 8 years ago

retest this please