search

feedhenry / fh-android-sdk

FeedHenry Android SDK
Apache License 2.0
5 stars 16 forks source link

Move from Maven to Gradle #101

Closed danielpassos closed 7 years ago

danielpassos commented 7 years ago

This PR is includes:

danielpassos commented 7 years ago

@secondsun I really want your review here, especially of README and test. Double check if I didn't forgot to add @Test on some method :pray:

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling e86ffe499fb5d6b3b3ac2c5bc62a69bc5d687301 on danielpassos:gradle into on feedhenry:gradle.

secondsun commented 7 years ago

@danielpassos once you add the packaging instructions in I will test with some template apps. In general I am +1 though.

danielpassos commented 7 years ago

@danielpassos once you add the packaging instructions in I will test with some template apps. In general I am +1 though.

@secondsun Going to create a new PR/issue for that.

danielpassos commented 7 years ago

Also, deps/android-async-http-1.4.9.jar and deps/httpclient-4.3.6.jar were removed, but only android-async-http is in library/build.gradle, is httpclient not needed anymore?

@jcesarmobile httpclient is a dependency in android-async-http

Also, the whole doc folder was removed, has it been moved elsewhere? or it isn't needed anymore?

@jcesarmobile Yes, It's automatically publish in http://javadoc.io/ for every release. There is badge linking to there

danielpassos commented 7 years ago

@jcesarmobile Apart of use https://access.redhat.com/documentation/ for docs. Done!

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 4f5a293ef7921ea4ea6096d30e196bc4b805dc3b on danielpassos:gradle into on feedhenry:gradle.

danielpassos commented 7 years ago

@jcesarmobile Done!