search

feedhenry / fh-android-sdk

FeedHenry Android SDK
Apache License 2.0
5 stars 16 forks source link

Json package optimisations #78

Closed psyren89 closed 8 years ago

psyren89 commented 8 years ago

This PR ports across updates made to the JSON package in the original repo, as well as general code formatting.

secondsun commented 8 years ago

@psyren89 Can you resubmit the PR to the FH-v3.8.0 branch? That is the current feature development branch.

psyren89 commented 8 years ago

@secondsun will do.

psyren89 commented 8 years ago

If the ultimate goal is to use a better maintained 3rd party library, is there any point in me reopening this PR?

matzew commented 8 years ago

If the ultimate goal is to use a better maintained 3rd party library, is there any point in me reopening this PR?

@psyren89 I think it might make sense for the 3.x series, but I think for 4.x we should get rid of the JSON.org packages, and use something that's available as a dependency via Maven, and also better maintained.

Also, the JSON.org stuff has a pretty bogus, non-free license: See here in the header: https://github.com/feedhenry/fh-android-sdk/blob/master/fh-android-sdk/src/main/java/org/json/fh/HTTP.java#L16