feedhenry / fh-android-sdk

FeedHenry Android SDK
Apache License 2.0
5 stars 16 forks source link

Undo AGDroid 3.0.x upgrade #94

Closed matzew closed 8 years ago

matzew commented 8 years ago

Since we and to release 3.1.0 (or should we actually name the JAR 3.0.1??) to Maven central,

I feel it's better to not include the 3.0.x of AGDroid, since that contains GCM-3 fixes...

matzew commented 8 years ago

@danielpassos @secondsun any comments ?

secondsun commented 8 years ago

-1, I think it is fine to leave.

matzew commented 8 years ago

So we are not releasing a 3.0.1 to maven central soon-ish?

If that's the case, I am fine. I am just concerned we do release the JAR, containing the GCM-3 changes. but than... it's just implementation details...

On Tue, May 24, 2016 at 7:02 PM, Hoyt Summers Pittman < notifications@github.com> wrote:

-1, I think it is fine to leave.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/feedhenry/fh-android-sdk/pull/94#issuecomment-221336942

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/ twitter: http://twitter.com/mwessendorf

secondsun commented 8 years ago

@matzew Should I close this because of the fcm work?

matzew commented 8 years ago

right! forgot about that :)