Committing to the open source

matzew commented 8 years ago

@grdryn ok, Jenkns bob builder updated

and here is the include of the the fh-db source to to be public

grdryn commented 8 years ago

:+1:

matzew commented 8 years ago

please test this

matzew commented 8 years ago

@grdryn any idea why no jenkins job is actually triggered ?

grdryn commented 8 years ago

Retest this please.

grdryn commented 8 years ago

@matzew The webook didn't get registered. I think this might be because of the teams not having been added in the settings view. I'll see if I can figure it out

matzew commented 8 years ago

test agains

grdryn commented 8 years ago

Retest this please.

grdryn commented 8 years ago

Retest this please.

fh-automatron commented 8 years ago

Pull Request Quality Guidelines

As we continue to focus on quality, here are a few things to keep in mind:

The code changes conform to the contributing & code style guides for this component (if they exist)
A component owner should review your change (we've tagged these above)
Automated testing has been added or updated for this change (e.g. UART, Unit/Acceptance tests)
If updating server component this PR should be deployed to a grid somewhere (via fhcap-cli) - please provide a link to this
Ensure JIRA is up to date before & after merge (e.g. deployment notes, tester notes, release notes, fix version)
Any SonarQube issues should be addressed where applicable (use your own judgement)

Please ping a component owner (see fh contrib) when your builds are complete, changes are deployed and you're ready for a review. Fhcap PR will be generated automatically. To deploy your changes to a cluster place comment in this PR with pattern [x][y] where x=deploy and y=clustername you wish to deploy. You can also deploy your change manually using fhcap-cli

feedhenry / fh-db

Committing to the open source #1

Pull Request Quality Guidelines