fh-automatron
commented
8 years ago Pull Request Quality Guidelines
As we continue to focus on quality, here are a few things to keep in mind:
- The code changes conform to the contributing & code style guides for this component (if they exist)
- A component owner should review your change (we've tagged these above)
- Automated testing has been added or updated for this change (e.g. UART, Unit/Acceptance tests)
- If updating server component this PR should be deployed to a grid somewhere (via
fhcap-cli) - please provide a link to this - Ensure JIRA is up to date before & after merge (e.g. deployment notes, tester notes, release notes, fix version)
- Any SonarQube issues should be addressed where applicable (use your own judgement)
Please ping a component owner (see fh contrib) when your builds are complete, changes are deployed and you're ready for a review.
Fhcap PR will be generated automatically.
To deploy your changes to a cluster place comment in this PR with pattern [x][y] where x=deploy and y=clustername you wish to deploy.
You can also deploy your change manually using fhcap-cli
Fixed the bug that was blocking the deletion and update of documents with ids that are not hex.
Before the PR, the delete and update calls were expecting hex values as the guid arguments.
Now, we try to convert the given argument to ObjectID and if it fails, we use the id as is.