Rhmap 11065 handle mongo restarts

feedhenry / fh-db

Apache License 2.0

1 stars 16 forks source link

Rhmap 11065 handle mongo restarts #15

Closed philipgough closed 7 years ago

philipgough commented 7 years ago

Motivation

Events were not being correctly emitted when there was an error with the connection to Mongo. Also, because some components dependent on fh-db need to listen for the close event, which was not being emitted, this was added

philbrookes commented 7 years ago

:+1: Reviewed.

fh-qube commented 7 years ago

SonarQube analysis reported 1 issue:

1 minor

Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

Reformat the code to have only one statement per line.

philbrookes commented 7 years ago

:+1: Nice, safer approach

philipgough commented 7 years ago

@philbrookes Yep, I have tested and the events are still emitted from the parent connection so no point in risking any uncaught breaking changes. Going to merge and publish. Thanks