search

feedhenry / fh-db

Apache License 2.0
1 stars 16 forks source link

FH-3084 Version bump #21

Closed aidenkeating closed 7 years ago

aidenkeating commented 7 years ago

The version bump for FH-3084 was missed. This bumps the version of fh-db from 1.3.1 to 1.4.0.

aidenkeating commented 7 years ago

@danbev Thanks for reminding me of this, would you mind taking a look?

danbev commented 7 years ago

👍 The changes look good to me. One thing that I noticed is that there are jshint errors locally, but these do not seem to be caught by the CI server.

aidenkeating commented 7 years ago

Do the CI jobs run jshint? I think it might only be using eslint

danbev commented 7 years ago

Do the CI jobs run jshint? I think it might only be using eslint

Looks like this project is still using jshint. At least that is what the output is telling me when running this locally. But this is not related to this PR