search

feedhenry / fh-db

Apache License 2.0
1 stars 16 forks source link

RHMAP-13690 - Unable to filter a collections documents by "_id" in DataBrowser #29

Closed rachael-oregan closed 7 years ago

rachael-oregan commented 7 years ago

Motivation

Users can't filter documents by _id in the databrowser.

Result

Add in the ability to filter documents with Date, Any or ObjectId type.

Note: included in this is the removal of the $in query option as it is no longer used.

Jira

https://issues.jboss.org/browse/RHMAP-13690

camilamacedo86 commented 7 years ago

@rachael-oregan,

This is with errors in the build. Could you check? Also, I believe that you need do a squash with the commits to have just one here instead 4 and a rebase of the master.

rachael-oregan commented 7 years ago

@pb82 @sedroche I split up the convertQueryType like suggested, let me know if the changes are ok

pb82 commented 7 years ago

Does it make sense to add test cases for ObjectId, Date and Any. For the Any test it would probably be enough to verify that the returned query is correct (equal to an expected query).

rachael-oregan commented 7 years ago

@pb82 ya it makes sense to add tests. I'll add them in now

fh-qube commented 7 years ago

SonarQube analysis reported 3 issues:

Watch the comments in this conversation to review them.

camilamacedo86 commented 7 years ago

I think we should solve the sonar issues before merge it.

camilamacedo86 commented 7 years ago

@rachael-oregan you merged it with sonar issues. I think you should solve it before merge.