search

feedhenry / fh-db

Apache License 2.0
1 stars 16 forks source link

Bugfix multiple restrictions #39

Closed compjuicer closed 6 years ago

compjuicer commented 6 years ago

When adding multiple restrictions for the same field, e.g. "gt" and "lt" on a field containing a unix timestamp to search within a range, only the last restriction is used in the query. The restrictions for the field do not build up in the query object, instead they overwrite eachother, leaving only the last one active.

camilamacedo86 commented 6 years ago

Hi @compjuicer,

Thank you for your collab 🥇 . Could you review this PR and do the following actions?

  1. In the first comment add the information as the following template.

JIRA:

WHAT:

WHY:

HOW:

STEPS TO TEST:

  1. Could you review your PR because it is not passing in the CI/Process and this is one of the pre-requirements for we are able to merge it?
screen shot 2018-05-25 at 08 36 36

Really thank you for your collaboration.

Cheers,

compjuicer commented 6 years ago

Hi Camila, I'm not sure why the CI fails, I don't think I touched any code related to that and couldn't really decipher the error message either: "Fatal error: If encoding is specified then the first argument must be a string".

damienomurchu commented 6 years ago

@compjuicer yes, CI error not very helpful. From a bit search it looks like this may be a bug in one of the dependencies we're using - perhaps the version of archiver - @grdryn do you have any thoughts ?

davidffrench commented 6 years ago

@compjuicer You are absolutely correct, the CI failure is not due to your changes.

grdryn commented 6 years ago

@compjuicer I've fixed the CI issue, so if you rebase these changes the job should pass for you now.

davidffrench commented 6 years ago

I have test out this change to fh-db locally and it works perfectly. Next step is to test this change across multiple scenarios (non-upgraded and upgraded db) and adding it to fh-ditch