feedhenry / fh-db

Apache License 2.0
1 stars 16 forks source link

Update to exclude replicaSet parameter if empty #9

Closed luigizuccarelli closed 8 years ago

luigizuccarelli commented 8 years ago

@matzew Please review

Please refer to JIRA RHMAP-9817

fh-automatron commented 8 years ago

Pull Request Quality Guidelines

As we continue to focus on quality, here are a few things to keep in mind:

Please ping a component owner (see fh contrib) when your builds are complete, changes are deployed and you're ready for a review. Fhcap PR will be generated automatically. To deploy your changes to a cluster place comment in this PR with pattern [x][y] where x=deploy and y=clustername you wish to deploy. You can also deploy your change manually using fhcap-cli

luigizuccarelli commented 8 years ago

Retest this please

luigizuccarelli commented 8 years ago

@philbrookes - please review when you have a chance

philbrookes commented 8 years ago

:+1: This look good to me, I can't think of any parameters here that would ever need to be an empty string.

luigizuccarelli commented 8 years ago

@philbrookes - Thanks, when we set the envar MONGODB_REPLICA_NAME in the template to empty it sets replicaSet='' and causes this problem