search

feedhenry / fh-fhc

FeedHenry CLI, the Command Line Interface to FeedHenry
Other
26 stars 66 forks source link

FH-3633 - Change the cmd configuration to follow the V3 standard and… #375

Closed camilamacedo86 closed 7 years ago

camilamacedo86 commented 7 years ago

JIRA: https://issues.jboss.org/browse/FH-3633

Following the changes made

Steps to verify

Following the local tests

Camilas-MacBook-Pro:fh-fhc cmacedo$ ./bin/fhc.js configuration set usqzucmg4uibvxknkete7smy windowsphone7 "remote Debug" true
{
  "status": "ok"
}
Camilas-MacBook-Pro:fh-fhc cmacedo$ ./bin/fhc.js configuration list usqzucmg4uibvxknkete7smy windowsphone7
{
  "auto Rotate": "true",
  "flurry Application Key": "",
  "keyTest": "valueTest",
  "orientation": "portrait",
  "packages": "",
  "remote Debug": "true",
  "splash Image": "",
  "status": "ok",
  "tile Image": "",
  "undefined": "false",
  "version Name": "1.0"
}
Camilas-MacBook-Pro:fh-fhc cmacedo$ ./bin/fhc.js configuration list usqzucmg4uibvxknkete7smy 
{
  "studio": {
    "packages": "",
    "root Folder": "/",
    "status": "ok"
  },
  "android": {
    "android Package Name": "",
    "auto Rotate": "true",
    "enable MonkeyTalk": "false",
    "flurry Application Key": "",
    "full Screen": "false",
    "orientation": "portrait",
    "packages": "",
    "permission Audio": "true",
    "permission Camera": "true",
    "permission Contacts": "true",
    "permission Location": "true",
    "permission Read Phone State": "true",
    "permission Receive SMS": "true",
    "permission Vibrate": "true",
    "remote Debug": "false",
    "splash Image": "",
    "status": "ok",
    "version Code": "1",
    "version Name": "1.0"
  },
  "embed": {
    "packages": "",
    "root Folder": "/",
    "status": "ok"
  },
  "iphone": {
    "activity Spinner": "Top",
    "app Id": "",
    "auto Hide Splash Screen": "true",
    "auto Rotate": "true",
    "background Audio": "false",
    "enable MonkeyTalk": "false",
    "flurry Application Key": "",
    "hide Status Bar": "false",
    "iphone5 Retina Splash Image": "",
    "old Style Status Bar": "false",
    "orientation": "portrait",
    "packages": "",
    "remote Debug": "false",
    "retina splash image": "",
    "simulator Only": "false",
    "splash Image": "",
    "status": "ok",
    "version Name": "1.0"
  },
  "ipad": {
    "activity Spinner": "Top",
    "app Id": "",
    "auto Hide Splash Screen": "true",
    "auto Rotate": "true",
    "background Audio": "false",
    "enable MonkeyTalk": "false",
    "flurry Application Key": "",
    "hide Status Bar": "false",
    "ipad Landscape Retina Splash Image": "",
    "ipad Retina Splash Image": "",
    "landscape splash image": "",
    "old Style Status Bar": "false",
    "orientation": "portrait",
    "packages": "",
    "remote Debug": "false",
    "simulator Only": "false",
    "splash Image": "",
    "status": "ok",
    "version Name": "1.0"
  },
  "blackberry": {
    "auto Rotate": "true",
    "flurry Application Key": "",
    "foreground Splash Image": "",
    "orientation": "portrait",
    "packages": "",
    "remote Debug": "false",
    "splash Background Color": "",
    "splash Image": "",
    "status": "ok",
    "version Name": "1.0"
  },
  "windowsphone7": {
    "auto Rotate": "true",
    "flurry Application Key": "",
    "keyTest": "valueTest",
    "orientation": "portrait",
    "packages": "",
    "remote Debug": "true",
    "splash Image": "",
    "status": "ok",
    "tile Image": "",
    "undefined": "false",
    "version Name": "1.0"
  }
}
Camilas-MacBook-Pro:fh-fhc cmacedo$
camilamacedo86 commented 7 years ago

@wei-lee Tks for your review and input here.

However, do you have sure that it is used just for Cordova lights? Because I understand that this command is destinated to perform changes into the configurations of for the builds. Following an example.

Change the value of the windowsphone7 for the prop "remote Debug": "true" to false.

Is not it something useful for all? Also, if it is just for Cordova light we, unfortunately, can not remove the support for Cordova light application until the end of the year and I would like that before that we had all commands already migrated for the V3 standard.

So, since we are not 100% sure about if it should or not be removed, what do you think about we migrate this one and make a JIRA to check if it is really useful or not in the future?

camilamacedo86 commented 7 years ago

@wei-lee it will be removed. I found the JIRA : https://issues.jboss.org/browse/RHMAP-12910