✨ update fhc build to work with self-managed build farm. Also

[wei-lee]

generate PR code

Motive

Small changes required to get fhc build to work with self-managed build farm.

Changes

1. Correctly resolve the url of artifacts and print them out
2. Print out QR code.

Verification

• fhc build should continue to work with a cluster that is using the SAAS build farm
• try fhc build again with this project in OSM4: https://osm4-rhmap.osm4.skunkhenry.com/#projects/xmd2inzuf5kakpmvetwtlku4/apps. It should work as well.

[aliok]

All good 👍

I executed fhc build for that application:

fhc build project=xmd2inzuf5kakpmvetwtlku4 app=xmd2in2athbzbudk2hd4liyr destination=android cloud_app=xmd2in2l3pi32gzphn4nttcd environment=dev tag=0.0.25
.......................................................................
Download URL: https://osm4-rhmap.osm4.skunkhenry.com/box/api/artifacts/download/WLTest-Helloworld-Native-Android-Gradle-App_xmd2in2athbzbudk2hd4liyr/23/app-debug.apk?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c
OTA URL: https://osm4-rhmap.osm4.skunkhenry.com/box/api/artifacts/ota/67f91c73-f44c-4ff1-8ffa-5cc925166f5e?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█ ▄▄▄▄▄ █▀▄▄██▄█▄█▀█▄▀ ▀ ▀▄▀ ▄▄▄▄ ▄█▀▄█ ▄▄▄▄▄ █
█ █   █ █▀▀▀█▀▄▄▄▀ ▀▄▀▀▀█▀▄█▄▄▀▄▄▄▄█ ▀█ █   █ █
█ █▄▄▄█ █▀▄ ▄▄▀ ▄▀ ▀▄ ▄▄▄ ▀▀ █▄▄█▀▀▄▄▄█ █▄▄▄█ █
█▄▄▄▄▄▄▄█▄▀▄█ █ █▄█ ▀ █▄█ ▀ ▀ █▄█ █ ▀ █▄▄▄▄▄▄▄█
█▄▄  ▄█▄ ▄▀ ▀▀▄▄▄▀▄▄  ▄▄ ▄ ▄█▀▀ ▄▀▄▄█▀▄█▄█▄█ ▀█
█ ██▀▀▀▄ █  █▄ ▄▄ ▄ ▄▄▄██▄▄▄█ ▀▀  ▄▄█ ▄ █ ▀ ▄██
█▄▄▄▀▀▀▄▄▄▄█ █▄▀▀▄▄▄█▀ ▄ ▄ █▄██ ██▀█▄▀▄█▄▀█▀ ▀█
█▀▀  ▀█▄██▀ ▀█▀█▀▄▄▄█▄▀█  █ ▀▀ ▀▄▀█ ▀▀ ▄ ▀▀ ▀██
█▀▄  █▄▄██▄▀▄▄▀█ █▀▄▄▄▀ ▀▄██▄█   ██▄ ▀███▀ ▀  █
██▄  █▄▄▀▄▄▀█▄▄▀▀▄▀ ▄▄███▄▀▄▀ ▀▀ ▀█ ▄ █▄ ▀▀▀▄██
█ █▄█ ▄▄▄ ▄▀▀▄▀▀▄▄█▄▀ ▄▄▄ ▄█▀█▀▀▀██▄▀ ▄▄▄ █▀▄▀█
█▀▀   █▄█   ▀ ▄ ▀█▄ █ █▄█    ▀▀█  ▀▄▄ █▄█ ▄▀▀██
█▀▄█  ▄▄  ▄█▄ ▄▄▄▄▄▄    ▄  ▄█▀▀▀ ▀█▄▀▄▄ ▄▄ ▀▀▀█
█▀██▄▀▄▄▄▄▄ ▄ ▄█▄█ ██▀ ▀▀▀▀▄█  ▀▀ ▄▄▀▄▀▀▀▄▀▀▄██
██▄▀█ ▄▄▄ ▀▀▀▀▀▀▀▄▀▄▀▀▀▀ █ █▄▀▄ █▀▄███ ▄█▄██▀ █
██▄▀ ▀▄▄▀▀▄ ▀ ▀█▀▀▄▄██▀▀▄▀█▄ ▀▄▀▄ ▄  ▀ ▀█ █▀█▀█
█ ██▀▀ ▄▄ ▀ ▀▄▀█▀▄▄▄  ▀▀▄▄ ██▀▀▀ ▀▀█▀▄ █▄▄█▀▄▀█
██▀▀▀ █▄ ▄ █▀█▄█▀▄▄▄▀▄███▀▄▄▄▀ ▀█▀█ ▀▄▀▀██▄ ▄██
█▄██▄▄█▄█ ▄▀▄▀▄▀▀▄▀▄▀ ▄▄▄ ▄█ ██  ██▄█ ▄▄▄ ▀██▀█
█ ▄▄▄▄▄ █▄██ ▄▄ ▄▄▀ ▄ █▄█ ▄▄▀▀▄█ ▀▄▄█ █▄█ ▄▀▄▀█
█ █   █ █ ▄█▄ ▄▄▀▄▀▄█ ▄▄  ▀█▀▀▄ ▄▀ █ ▄▄▄  ▀█ ██
█ █▄▄▄█ █ ██▄ ▀▀▀▄ ▄█▀ ▄▀█▀▄▀ ██▄   ▀ ▀▄█▀▄ █▄█
█▄▄▄▄▄▄▄█▄▄█████▄▄▄▄▄████▄████▄▄▄██▄█▄█▄█▄▄█▄██

Downloading the artifacts using wget was successful:

ali@Alis-MacBook-Pro:/tmp$ wget https://osm4-rhmap.osm4.skunkhenry.com/box/api/artifacts/download/WLTest-Helloworld-Native-Android-Gradle-App_xmd2in2athbzbudk2hd4liyr/23/app-debug.apk?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c
--2017-08-02 12:05:33--  https://osm4-rhmap.osm4.skunkhenry.com/box/api/artifacts/download/WLTest-Helloworld-Native-Android-Gradle-App_xmd2in2athbzbudk2hd4liyr/23/app-debug.apk?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c
Resolving osm4-rhmap.osm4.skunkhenry.com... 52.19.216.112
Connecting to osm4-rhmap.osm4.skunkhenry.com|52.19.216.112|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/vnd.android.package-archive]
Saving to: ‘app-debug.apk?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c’

app-debug.apk?token     [          <=>       ]   2.82M   455KB/s    in 5.6s    

2017-08-02 12:05:39 (513 KB/s) - ‘app-debug.apk?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c’ saved [2955042]

ali@Alis-MacBook-Pro:/tmp$ wget https://osm4-rhmap.osm4.skunkhenry.com/box/api/artifacts/ota/67f91c73-f44c-4ff1-8ffa-5cc925166f5e?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c
--2017-08-02 12:05:46--  https://osm4-rhmap.osm4.skunkhenry.com/box/api/artifacts/ota/67f91c73-f44c-4ff1-8ffa-5cc925166f5e?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c
Resolving osm4-rhmap.osm4.skunkhenry.com... 52.19.216.112
Connecting to osm4-rhmap.osm4.skunkhenry.com|52.19.216.112|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/vnd.android.package-archive]
Saving to: ‘67f91c73-f44c-4ff1-8ffa-5cc925166f5e?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c’

67f91c73-f44c-4ff1-     [                <=> ]   2.82M   716KB/s    in 4.2s    

2017-08-02 12:05:51 (693 KB/s) - ‘67f91c73-f44c-4ff1-8ffa-5cc925166f5e?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c’ saved [2955042]

Artifacts listed fine:

ali@Alis-MacBook-Pro:/tmp$ fhc artifacts --app=xmd2in2athbzbudk2hd4liyr
┏━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Platform    ┃ App Version ┃ Date                    ┃ Type  ┃ Credential ┃ Url                                                                                                                                              ┃
┣━━━━━━━━━━━━━╋━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━╋━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
┃ android     ┃ 33          ┃ 2017-08-02 09:03:10:049 ┃ debug ┃            ┃ https://osm4-rhmap.osm4.skunkhenry.com/box/api/artifacts/ota/67f91c73-f44c-4ff1-8ffa-5cc925166f5e?token=483d6e49d30e0d1e5a49262a2eb8b86df4fa334c ┃
┣━━━━━━━━━━━━━╋━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━╋━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

@wei-lee the my qr code scanning app was not able read the qr code generated. I use this: https://play.google.com/store/apps/details?id=com.google.zxing.client.android&hl=en

[aliok]

@wei-lee just one comment... Can we make the "tag" parameter mandatory? I was not using it initially and was getting weird errors. Is there a case where that tag is not required?

[wei-lee]

@aliok yes, I will make it mandatory on the server side.

[camilamacedo86]

@wei-lee I think we already did this as mandatory in the past and we had a lot of complaints about it because of if the customer doesn't define the tag should be the next available. So, I think it is perfect in this way :-) Just the sonar issues, but this command at some moment will be moved anyway to the V3 standard and we can try to fix the sonar issue there.

Great work :-)

[wei-lee]

@camilamacedo86 right, cool. I think I should be able to fix that.

[wei-lee]

@camilamacedo86 I have updated millicore so that the next available tag will be used if it's not provided. See https://github.com/fheng/millicore/pull/947

[camilamacedo86]

@wei-lee fantastic !!!!

[fh-qube]

SonarQube analysis reported 2 issues:

• 2 minor

Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

• Function has a complexity of 24 which is greater than 20 authorized.
• Function has a complexity of 23 which is greater than 20 authorized.