FH-3874 - Tests into the root of fh3 directory have not been called into the unit tests

feedhenry / fh-fhc

FeedHenry CLI, the Command Line Interface to FeedHenry

Other

26 stars 66 forks source link

FH-3874 - Tests into the root of fh3 directory have not been called into the unit tests #401

Closed camilamacedo86 closed 7 years ago

camilamacedo86 commented 7 years ago

JIRA: https://issues.jboss.org/browse/FH-3874

Changes

Fix path into Gruntfile.js in order to run/call all test files into the directory unit/test/fh3
Fix all tests which were into the /
Fix bug related to the import of zip files. ( This bug was not found before because of this its unit have been not called )

Step to verify

Check into the build of the Jenkins that the files into the root of test/unit/fh3/ dir were called - E.g - Looking for test_ping.js it into the print of console.log

camilamacedo86 commented 7 years ago

@wei-lee tks for your review. I will re-check it. After this change the tests into the root are being called, however, I think that test into the tree of the directory are not so long and all need be called. I will fix that :-)

camilamacedo86 commented 7 years ago

@wei-lee Done. Could you check, please?

camilamacedo86 commented 7 years ago

@wei-lee I am pinging you here because it is open for a while and I believe that the last ping was missed. It will be wonderful if you are able to recheck it. Please, let me know if we can approve it and merge or if has anything else that you think that is required be done here in order to we are able to do it.