search

feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK
http://feedhenry.org
Apache License 2.0
6 stars 16 forks source link

fh-ios-sdk project should contain only library+tests target #15

Closed cvasilak closed 9 years ago

cvasilak commented 9 years ago

Motivation: Currently the fh-ios-sdk xcode project apart from the library contained demo targets. This PR extracts the library as a standalone target including the tests. The demo included in the project was extracted into a separate demo project. All other demos in the repo were moved in the /demos folder. Eventually these demos will be moved out from the repo too.

To test: Simple open fh-ios-sdk.xcodeproj and run Product->Tests. Project should be build and tests run successfully. Further the build.sh script was adjusted and should create the framework build plus the starter project (as before) in the /dist folder.

Note the /dist folder was removed from the repo. As discussed with @wei-lee we can use the 'Release' feature of Github to publish the released artifacts instead of holding them in the repo itself.

@wei-lee mind to review?

wei-lee commented 9 years ago

Reviewed. Verified the project does build and described in the above comment.

Just having another question about moving the demo projects. Previously they are not really for "demo" purpose, but for testing purpose - for example, the fh-ios-sdk is a dependent project of the sync test app. I can easily make changes to the ios-sdk project and then testing it by just building the sync app. But now it looks like I have to build the sdk and copy the FH.framework to the sync test app to test. Am I correct?

cvasilak commented 9 years ago

thank you @wei-lee for reviewing

already have made adjustments to the build.sh script so once you have build the project, the fwk are copied to each respective demo folder, so opening each one of the them, you can immediately test with the latest framework build (as before).

In essence, no need to do any manual copy, it will be handled auto from the build script, you simply run the demo project for immediate testing.

wei-lee commented 9 years ago

Fair enough. Good job! :+1: