Closed cvasilak closed 9 years ago
@wei-lee @corinnekrych mind to review
:eyes:
@cvasilak @wei-lee is the choice to have Pods folder to ease build farm build? +1 for development pod, I've tried it on another project and it's very nice when you have demos in same repo +1 for Podfile.lock But still wondering for Pods folder. Still looking in more details :eyes:
@cvasilak Great work! I've done a small PR on your PR to remove warning on cocoapods https://github.com/cvasilak/fh-ios-sdk/pull/1
@vibe13 are you ok on removing build.sh in favor of cocoapods private repo for building?
@cvasilak :+1: This is great. Indeed build farm doesn't support cocoapods yet. But we don't need to build the sdk using build farm. We can still use the generated FH.framework in the apps.
Motivation: This PR add's convenient cocoapods support in the fh-ios-sdk so it can be easily installed by devs that use this kind of installation method. During this work, more cleanups were made to ease the maintenance burden. In particular:
Cocoapods
plusGitHub
. Previously the release (framework/api docs generation) was scattered in separate scripts and procedures but currently we utilise cocoapods as the tool to encapsulate the process under a common umbrella, with clear visible steps. We are actively looking the coccoapods approach and if it will make sense in the 'productization' phase, if not all this separate steps and Xcode targets will be encapsulated in a single script rather the scatter in multiple places. The cleaning work that has been done in this PR will help us later on./demos
folder use a Podfile now and were converted to utilise the 'Development Pod' feature of cocoapods so opening a demo links to the original source's (e.g symbolic link), no need for a separatepod install
once a library change is made. This will help during dev and debugging so the changes are immediate visible. @wei-lee this means that you can have the demo application only open, make changes to the library and be immediate visible ;)Notes:
To test:
fh-ios-sdk.xcworkspace
, Build/Tests should both complete successfully.pod install
and fire up the application to test. Currently the demo uses a private repo but once the PR is merged I am going to push the Podspec to the official cocoapods repository as our first release, and be immediate visible to outside developers