feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK
http://feedhenry.org
Apache License 2.0
6 stars 16 forks source link

Introduce cocoapods #20

Closed cvasilak closed 9 years ago

cvasilak commented 9 years ago

Motivation: This PR add's convenient cocoapods support in the fh-ios-sdk so it can be easily installed by devs that use this kind of installation method. During this work, more cleanups were made to ease the maintenance burden. In particular:

Notes:

To test:

Next step is to look at supporting a cocoapod build inside the fh-digger-node built farm, as part of FHMOBSDK-60

cvasilak commented 9 years ago

@wei-lee @corinnekrych mind to review

corinnekrych commented 9 years ago

:eyes:

corinnekrych commented 9 years ago

@cvasilak @wei-lee is the choice to have Pods folder to ease build farm build? +1 for development pod, I've tried it on another project and it's very nice when you have demos in same repo +1 for Podfile.lock But still wondering for Pods folder. Still looking in more details :eyes:

corinnekrych commented 9 years ago

@cvasilak Great work! I've done a small PR on your PR to remove warning on cocoapods https://github.com/cvasilak/fh-ios-sdk/pull/1

@vibe13 are you ok on removing build.sh in favor of cocoapods private repo for building?

wei-lee commented 9 years ago

@cvasilak :+1: This is great. Indeed build farm doesn't support cocoapods yet. But we don't need to build the sdk using build farm. We can still use the generated FH.framework in the apps.